fix: select database fix #16472
fix: select database fix #16472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16472 +/- ##
=======================================
Coverage 76.61% 76.61%
=======================================
Files 1002 1002
Lines 53671 53674 +3
Branches 6857 6857
=======================================
+ Hits 41121 41124 +3
Misses 12311 12311
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AAfghahi
force-pushed
the
ch24461_undefinedBackend
branch
from
0d2d9c8
to
6f5c20a
Compare
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://34.222.20.224:8080. Credentials are |
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://54.184.0.64:8080. Credentials are |
There was a problem hiding this comment.
LGTM, thanks for the fix! We may want to clean up some of these methods at some point, as we seem to have multiple different codepaths to get more or less the same data (see e.g. Database.data() which has essentially the same data but slightly different property names)
|
@villebro yeah that has been in our backlog for a while |
|
Ephemeral environment shutdown and build artifacts deleted. |
|
🏷 2021.34 |
* select database fix * made a backend change (cherry picked from commit e246916)
* select database fix * made a backend change
* select database fix * made a backend change
mistercrunch
added
🏷️ bot
SUMMARY
This fixes the issue where the first database in the select database list shows undefined for its backend.
The reason that this issue was occurring is that backend is not available on the first render, which is why there is a placeholder.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION