fix(explore): timestamp format when copy datatable to clipboard #17166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
force-pushed
the
fix/copy-datatable
branch
from
417cfe0
to
61b8e21
Compare
kgabryje
force-pushed
the
fix/copy-datatable
branch
from
61b8e21
to
8311a51
Compare
geido
reviewed
Oct 20, 2021
superset-frontend/src/explore/components/DataTableControl/index.tsx
Outdated
Show resolved
Hide resolved
zhaoyongjie
reviewed
Oct 21, 2021
Comment on lines
108
to
111
| return data.filter((row: Record<string, any>) => | ||
| Object.values(row).some(value => | ||
| value?.toString().toLowerCase().includes(filterText.toLowerCase()), | ||
| ), |
There was a problem hiding this comment.
a bit performance optimization, could we process the row of data before calling useFilteredTableData? (in the other words, pre-process every cell into string)
There was a problem hiding this comment.
Done. Is that what you meant?
zhaoyongjie
approved these changes
Oct 21, 2021
kgabryje
force-pushed
the
fix/copy-datatable
branch
from
dd9de2c
to
31b1234
Compare
kgabryje
force-pushed
the
fix/copy-datatable
branch
from
31b1234
to
815b3fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #17166 +/- ##
==========================================
+ Coverage 76.91% 76.94% +0.02%
==========================================
Files 1039 1039
Lines 55559 55576 +17
Branches 7567 7574 +7
==========================================
+ Hits 42733 42761 +28
+ Misses 12576 12565 -11
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…he#17166) * fix(explore): timestamp format when copy datatable to clipboard * Fix test * Fix test * Use translation for aria label * Memoize stringified cells * Fix test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user copied a data with timestamp to clipboard from data table in Exlore view, the timestamp was copied without formatting. This PR fixes that issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see linked issue
After:
Screen.Recording.2021-10-20.at.11.54.16.mov
TESTING INSTRUCTIONS
__timestampcolumn in it's dataADDITIONAL INFORMATION
CC @junlincc @jinghua-qa