Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Fix issue #17144 - Resetting native filter form does not clear the values. #17217

Merged

Conversation

m-ajay
Copy link
Contributor

@m-ajay m-ajay commented Oct 25, 2021

SUMMARY

Fix issue #17144

TESTING INSTRUCTIONS

  1. Test manually

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: DASHBOARD_NATIVE_FILTERS, DASHBOARD_NATIVE_FILTERS_SET, DASHBOARD_CROSS_FILTERS, DASHBOARD_NATIVE_FILTERS_SET, DASHBOARD_FILTERS_EXPERIMENTAL
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #17217 (6315821) into master (4f1d202) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17217   +/-   ##
=======================================
  Coverage   76.86%   76.87%           
=======================================
  Files        1039     1038    -1     
  Lines       55608    55618   +10     
  Branches     7580     7585    +5     
=======================================
+ Hits        42744    42756   +12     
+ Misses      12614    12612    -2     
  Partials      250      250           
Flag Coverage Δ
javascript 71.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.71% <100.00%> (ø)
...erset-frontend/src/components/Pagination/index.tsx 72.72% <0.00%> (-27.28%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 74.28% <0.00%> (-0.25%) ⬇️
...frontend/src/components/DatabaseSelector/index.tsx 95.00% <0.00%> (-0.13%) ⬇️
...tersConfigModal/FiltersConfigForm/ColumnSelect.tsx 96.07% <0.00%> (-0.08%) ⬇️
...frontend/src/components/TimezoneSelector/index.tsx 97.72% <0.00%> (-0.06%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 61.13% <0.00%> (ø)
.../src/dashboard/components/RefreshIntervalModal.tsx 89.47% <0.00%> (ø)
...ore/components/controls/DateFilterControl/types.ts 100.00% <0.00%> (ø)
...ents/controls/DateFilterControl/utils/constants.ts 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1d202...6315821. Read the comment docs.

@geido
Copy link
Member

geido commented Oct 26, 2021

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DASHBOARD_NATIVE_FILTERS_SET=true FEATURE_DASHBOARD_FILTERS_EXPERIMENTAL=true

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.185.8.203:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! i'll merge now

@etr2460 etr2460 merged commit 743f4b6 into apache:master Oct 27, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants