Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle constraints in db migration for MySQL 8 #17274

Closed
wants to merge 1 commit into from

Conversation

exemplary-citizen
Copy link
Contributor

SUMMARY
fix for db migration issue introduced in #16756

TESTING INSTRUCTIONS
Watch CI and any suggestions from reviewers

cc: @betodealmeida

@exemplary-citizen exemplary-citizen requested a review from a team as a code owner October 28, 2021 22:23
@superset-github-bot superset-github-bot bot added the dropbox Dropbox related label Oct 28, 2021
@exemplary-citizen exemplary-citizen changed the title fix db migration for MySQL 8 fix: handle constraints in db migration for MySQL 8 Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #17274 (518e7ad) into master (ce558e0) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17274      +/-   ##
==========================================
- Coverage   77.02%   76.95%   -0.08%     
==========================================
  Files        1037     1037              
  Lines       55629    55629              
  Branches     7594     7594              
==========================================
- Hits        42851    42807      -44     
- Misses      12528    12572      +44     
  Partials      250      250              
Flag Coverage Δ
hive 81.52% <ø> (ø)
mysql 81.95% <ø> (ø)
postgres 81.96% <ø> (ø)
presto ?
python 82.31% <ø> (-0.16%) ⬇️
sqlite 81.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 84.30% <0.00%> (-6.07%) ⬇️
superset/connectors/sqla/models.py 85.99% <0.00%> (-1.41%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce558e0...518e7ad. Read the comment docs.

@betodealmeida
Copy link
Member

betodealmeida commented Oct 28, 2021

@exemplary-citizen did you test this on an existing install with MySQL 8?

I don't think it will work because the constraint will already be there for existing installations, and for new installations it will be created before this migration runs.

@betodealmeida
Copy link
Member

I think we need to do something like this: #17275

@exemplary-citizen
Copy link
Contributor Author

@betodealmeida you're right it is still failing. closing in favor of your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dropbox Dropbox related size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants