-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import should accept old keys #17330
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17330 +/- ##
==========================================
- Coverage 77.15% 76.97% -0.19%
==========================================
Files 1037 1036 -1
Lines 55639 55686 +47
Branches 7612 7627 +15
==========================================
- Hits 42930 42862 -68
- Misses 12459 12568 +109
- Partials 250 256 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3c7c3b1
to
843ea31
Compare
* fix: import should accept old keys * Fix lint * Preserve V1 schema
This reverts commit 0b8507f.
* fix: import should accept old keys * Fix lint * Preserve V1 schema
SUMMARY
#16756 renamed a few fields on a versioned schema, breaking import/export, since old exports are no longer valid.
I reverted the schema to the original V1, and fixed export to produce the original schema. I also fixed the import to support the new keys, since exports might've been made with the incorrect schema.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION