Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not show migration toast if user not enable dashboard filter components #17440

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Nov 15, 2021

SUMMARY

To prepare remove filter_box, #16992 introduced modal and toast message if user still using filter_box in dashboard.

But for users in the company that not have filter component feature yet, this message looks very confusing. We should not show migration message if user not enabling dashboard filter component.

Screen Shot 2021-11-15 at 9 54 52 AM

ADDITIONAL INFORMATION

cc @michael-s-molina @etr2460

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the quick fix!

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #17440 (03be65b) into master (9741eaa) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 03be65b differs from pull request most recent head 791d7e9. Consider uploading reports for the commit 791d7e9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17440      +/-   ##
==========================================
- Coverage   76.94%   76.94%   -0.01%     
==========================================
  Files        1042     1042              
  Lines       56248    56249       +1     
  Branches     7784     7785       +1     
==========================================
  Hits        43280    43280              
- Misses      12709    12710       +1     
  Partials      259      259              
Flag Coverage Δ
javascript 71.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/dashboard/containers/DashboardPage.tsx 25.51% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9741eaa...791d7e9. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 9f1bf1c into apache:master Nov 15, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants