Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate EstimateQueryCostButton component from jsx to tsx #17603

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

Damans227
Copy link
Contributor

SUMMARY

PR for migrating EstimateQueryCostButton component from JSX to TSX

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [TRACKER] Migrate JavaScript files to TypeScript #10004
  • Enhancement (new features, refinement)
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Damans227
Copy link
Contributor Author

@etr2460 Ptal, thx!

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #17603 (e31b4c7) into master (95177d7) will increase coverage by 0.02%.
The diff coverage is 59.63%.

❗ Current head e31b4c7 differs from pull request most recent head 853cae2. Consider uploading reports for the commit 853cae2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17603      +/-   ##
==========================================
+ Coverage   68.52%   68.55%   +0.02%     
==========================================
  Files        1588     1601      +13     
  Lines       64947    65266     +319     
  Branches     6963     6966       +3     
==========================================
+ Hits        44505    44741     +236     
- Misses      18552    18635      +83     
  Partials     1890     1890              
Flag Coverage Δ
javascript 57.07% <11.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qlLab/components/EstimateQueryCostButton/index.tsx 34.48% <11.11%> (ø)
superset/key_value/api.py 41.46% <41.46%> (ø)
superset/dashboards/filter_state/commands/get.py 50.00% <50.00%> (ø)
superset/key_value/commands/create.py 57.14% <57.14%> (ø)
superset/key_value/commands/get.py 57.14% <57.14%> (ø)
superset/key_value/commands/update.py 57.69% <57.69%> (ø)
superset/connectors/base/models.py 88.19% <60.00%> (-0.49%) ⬇️
superset/key_value/commands/delete.py 60.00% <60.00%> (ø)
...uperset/dashboards/filter_state/commands/create.py 63.63% <63.63%> (ø)
...uperset/dashboards/filter_state/commands/delete.py 63.63% <63.63%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95177d7...853cae2. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments, more related to the component than your changes tbh

…n/index.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 1, 2021
@Damans227 Damans227 force-pushed the enhancement/migrate-jsx-to-tsx_6 branch from 3386851 to 511b4b8 Compare December 1, 2021 01:20
@pull-request-size pull-request-size bot added size/M and removed size/L labels Dec 1, 2021
@Damans227 Damans227 force-pushed the enhancement/migrate-jsx-to-tsx_6 branch from 8045cf1 to dad2c0b Compare December 1, 2021 01:29
@Damans227 Damans227 force-pushed the enhancement/migrate-jsx-to-tsx_6 branch from dad2c0b to eca9815 Compare December 1, 2021 01:49
@Damans227 Damans227 force-pushed the enhancement/migrate-jsx-to-tsx_6 branch 2 times, most recently from d079b56 to 1903e3d Compare December 1, 2021 14:06
@Damans227 Damans227 force-pushed the enhancement/migrate-jsx-to-tsx_6 branch from 1903e3d to 853cae2 Compare December 1, 2021 14:33
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the iteration!

@etr2460 etr2460 merged commit c6ba9bf into apache:master Dec 1, 2021
@Damans227 Damans227 deleted the enhancement/migrate-jsx-to-tsx_6 branch December 1, 2021 17:29
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants