-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate EstimateQueryCostButton component from jsx to tsx #17603
chore: migrate EstimateQueryCostButton component from jsx to tsx #17603
Conversation
@etr2460 Ptal, thx! |
Codecov Report
@@ Coverage Diff @@
## master #17603 +/- ##
==========================================
+ Coverage 68.52% 68.55% +0.02%
==========================================
Files 1588 1601 +13
Lines 64947 65266 +319
Branches 6963 6966 +3
==========================================
+ Hits 44505 44741 +236
- Misses 18552 18635 +83
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, more related to the component than your changes tbh
superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
Outdated
Show resolved
Hide resolved
…n/index.tsx Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
3386851
to
511b4b8
Compare
8045cf1
to
dad2c0b
Compare
dad2c0b
to
eca9815
Compare
superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
Outdated
Show resolved
Hide resolved
d079b56
to
1903e3d
Compare
1903e3d
to
853cae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the iteration!
SUMMARY
PR for migrating
EstimateQueryCostButton
component from JSX to TSXBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION