Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add AutoSizer to react-virtualized Grid #17606

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Nov 30, 2021

SUMMARY

The react-virtualized.Grid was having rendering issues due to setting an outrageous with on the div. To fix this we've add the AutoSizer component to dynamically set the width based upon the users client size.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
master.mov
After
improv.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title Grid improv improve: Add AutoSizer to react-virtualized Grid Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #17606 (b2682ca) into master (95177d7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17606      +/-   ##
==========================================
+ Coverage   68.52%   68.57%   +0.04%     
==========================================
  Files        1588     1588              
  Lines       64947    64948       +1     
  Branches     6963     6963              
==========================================
+ Hits        44505    44537      +32     
+ Misses      18552    18525      -27     
+ Partials     1890     1886       -4     
Flag Coverage Δ
hive 81.61% <ø> (ø)
javascript 57.03% <100.00%> (-0.04%) ⬇️
mysql 82.03% <ø> (ø)
postgres 82.04% <ø> (ø)
presto 81.91% <ø> (?)
python 82.53% <ø> (+0.14%) ⬆️
sqlite 81.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.tsx 66.85% <100.00%> (-7.29%) ⬇️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 88.42% <0.00%> (+1.34%) ⬆️
superset/db_engine_specs/presto.py 90.39% <0.00%> (+6.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95177d7...b2682ca. Read the comment docs.

@hughhhh hughhhh changed the title improve: Add AutoSizer to react-virtualized Grid refactor: Add AutoSizer to react-virtualized Grid Dec 1, 2021
@geido
Copy link
Member

geido commented Dec 1, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

@geido Ephemeral environment spinning up at http://54.202.41.249:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see how the problem looked like before these changes as I cannot reproduce it. It would be great to add a video or a screenshot here. However, the code looks fine and also manual testing seems ok. Thank you!

@hughhhh
Copy link
Member Author

hughhhh commented Dec 1, 2021

I would like to see how the problem looked like before these changes as I cannot reproduce it. It would be great to add a video or a screenshot here. However, the code looks fine and also manual testing seems ok. Thank you!

Just added videos, let me know what you think

<>
<AutoSizer disableHeight>
{({ width }) => (
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you got rid of the two separate divs (and also got rid of their classnames). Has that affected any of the css for right and left Column?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I can see the class was mostly around positioning from the react virtualized, but the styling wise doesn't effect the component

@hughhhh hughhhh merged commit d9e9c3a into master Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the grid-improv branch March 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants