-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add AutoSizer to react-virtualized Grid
#17606
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17606 +/- ##
==========================================
+ Coverage 68.52% 68.57% +0.04%
==========================================
Files 1588 1588
Lines 64947 64948 +1
Branches 6963 6963
==========================================
+ Hits 44505 44537 +32
+ Misses 18552 18525 -27
+ Partials 1890 1886 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Grid
Grid
/testenv up |
@geido Ephemeral environment spinning up at http://54.202.41.249:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see how the problem looked like before these changes as I cannot reproduce it. It would be great to add a video or a screenshot here. However, the code looks fine and also manual testing seems ok. Thank you!
Just added videos, let me know what you think |
<> | ||
<AutoSizer disableHeight> | ||
{({ width }) => ( | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh you got rid of the two separate divs (and also got rid of their classnames). Has that affected any of the css for right and left Column?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what I can see the class was mostly around positioning from the react virtualized, but the styling wise doesn't effect the component
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The
react-virtualized.Grid
was having rendering issues due to setting an outrageous with on the div. To fix this we've add theAutoSizer
component to dynamically set the width based upon the users client size.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
master.mov
After
improv.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION