Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import typeddict from extensions #17823

Merged
merged 1 commit into from
Dec 20, 2021
Merged

fix: import typeddict from extensions #17823

merged 1 commit into from
Dec 20, 2021

Conversation

villebro
Copy link
Member

SUMMARY

TypedDict was only added to Python 3.8, so as long as we're still supporting Python 3.7, we need to import it from typing_extensions. Fixes #17802

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

kgabryje
kgabryje approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 0199104 into apache:master Dec 20, 2021
@villebro villebro deleted the villebro/py37-typeddict branch December 20, 2021 08:22
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@villebro @shcoderAlex
fix: import typeddict from extensions (apache#17823)
a2c2c33
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@villebro @bwang221
fix: import typeddict from extensions (apache#17823)
5f70e26
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villebro @kgabryje @mistercrunch