-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(monorepo): update plugin dependencies #17837
Conversation
message="chore: publish $tag" | ||
|
||
# Update the lock file here | ||
rm "$rootDir/package-lock.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to update lock file when use file dependencies in packages.json
Codecov Report
@@ Coverage Diff @@
## master #17837 +/- ##
==========================================
- Coverage 67.03% 66.98% -0.06%
==========================================
Files 1608 1609 +1
Lines 64817 64865 +48
Branches 6852 6863 +11
==========================================
- Hits 43451 43450 -1
- Misses 19507 19551 +44
- Partials 1859 1864 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a175f5e
to
50c3ae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor nit
c09ebbd
to
4a894be
Compare
* refactor(monorepo): use local dependencies in packages.json * add prettier ignore * update commit message * fix release workflow * refine release script
* refactor(monorepo): use local dependencies in packages.json * add prettier ignore * update commit message * fix release workflow * refine release script
SUMMARY
local dependencies
replace with the version dependencies in package.jsonBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION