Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused eslintrc #17860

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Dec 23, 2021

SUMMARY

This PR will simplify the config of eslint and speed up the lint stage

After lint speed

image

Before lint speed

image

  1. removed useless .eslintrc in the codebase
    a) superset-frontend/src/common/components/.eslintrc
    b) superset-frontend/src/components/.eslintrc
    c) superset-frontend/src/dashboard/.eslintrc
  2. improved minor code-smell (just style)
    a) superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
    b) superset-frontend/src/middleware/asyncEvent.ts
  3. removed dependency file-loader, because file-loader has replaced with asset/resource in PR-17909
  4. removed dependency eslint-import-resolver-webpack. We have set 'import/core-modules' in .eslintrc.js for resolver.
  5. removed useless overrides settings in .eslintrc.js
    a) files: ['cypress-base/**/*']
    b) files: ['webpack*.js']
    c) files: ['*.stories.jsx', '*.stories.tsx']
    d) files: './packages/generator-superset/**/*.test.*'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title chore: import antd from common chore: import antd from common lib Dec 23, 2021
@zhaoyongjie zhaoyongjie changed the title chore: import antd from common lib chore: remove unused eslintrc Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #17860 (5577508) into master (97a78d3) will not change coverage.
The diff coverage is 18.18%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17860   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64903    64903           
  Branches     6866     6866           
=======================================
  Hits        43535    43535           
  Misses      19502    19502           
  Partials     1866     1866           
Flag Coverage Δ
javascript 53.77% <18.18%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ashboard/components/gridComponents/ChartHolder.jsx 58.82% <0.00%> (ø)
superset-frontend/src/middleware/asyncEvent.ts 69.46% <20.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97a78d3...5577508. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work removing the duplications and lowering the complexity!

@zhaoyongjie zhaoyongjie merged commit ceecc70 into apache:master Jan 5, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
* chore: remove unused eslintrc

* remove unused lint

* add comments

* change comments
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
* chore: remove unused eslintrc

* remove unused lint

* add comments

* change comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants