Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate DeleteComponentButton to TypeScript #18136

Merged
merged 6 commits into from
Feb 11, 2022
Merged

refactor: migrate DeleteComponentButton to TypeScript #18136

merged 6 commits into from
Feb 11, 2022

Conversation

Scrip7
Copy link
Contributor

@Scrip7 Scrip7 commented Jan 22, 2022

SUMMARY

Migrated DeleteComponentButton to TypeScript to apply direction outlined in #18100 .

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No changes

TESTING INSTRUCTIONS

The storybook can be used to verify those changes.

ADDITIONAL INFORMATION

  • Has associated issue: Migrate components to TypeScript #18100
  • Required feature flags: no
  • Changes UI: no
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API: no
  • Removes existing feature or API: no

@ad-m , @zhaoyongjie , @kristw

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #18136 (7d4fbcc) into master (0cec0c9) will increase coverage by 0.34%.
The diff coverage is n/a.

❗ Current head 7d4fbcc differs from pull request most recent head aa5091d. Consider uploading reports for the commit aa5091d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18136      +/-   ##
==========================================
+ Coverage   65.95%   66.29%   +0.34%     
==========================================
  Files        1584     1595      +11     
  Lines       62046    62590     +544     
  Branches     6273     6302      +29     
==========================================
+ Hits        40920    41494     +574     
+ Misses      19505    19451      -54     
- Partials     1621     1645      +24     
Flag Coverage Δ
javascript 51.33% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/teradata.py 62.75% <0.00%> (-27.25%) ⬇️
...rontend/src/explore/components/EmbedCodeButton.jsx 66.66% <0.00%> (-12.29%) ⬇️
superset/key_value/api.py 81.52% <0.00%> (-9.97%) ⬇️
...dashboard/components/menu/ShareMenuItems/index.tsx 65.38% <0.00%> (-8.53%) ⬇️
...nd/src/explore/components/ExploreActionButtons.tsx 57.14% <0.00%> (-5.72%) ⬇️
...rc/explore/components/controls/TextAreaControl.jsx 80.00% <0.00%> (-4.22%) ⬇️
.../src/dashboard/components/gridComponents/Chart.jsx 58.88% <0.00%> (-4.21%) ⬇️
superset/views/dashboard/views.py 65.16% <0.00%> (-4.07%) ⬇️
superset/security/api.py 96.49% <0.00%> (-3.51%) ⬇️
...uperset-frontend/src/explore/exploreUtils/index.js 63.90% <0.00%> (-3.00%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cec0c9...aa5091d. Read the comment docs.

@Scrip7
Copy link
Contributor Author

Scrip7 commented Jan 23, 2022

@ad-m I've made mentioned changes.

@AAfghahi AAfghahi self-requested a review January 27, 2022 20:17
@Scrip7 Scrip7 requested a review from AAfghahi January 28, 2022 14:58
@Scrip7 Scrip7 requested a review from AAfghahi January 29, 2022 06:35
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Would you be interested in moving it to a functional component as well?

@Scrip7
Copy link
Contributor Author

Scrip7 commented Feb 8, 2022

@geido I've moved it to functional component

@geido
Copy link
Member

geido commented Feb 9, 2022

Thanks @Scrip7! Now running CI

@Scrip7
Copy link
Contributor Author

Scrip7 commented Feb 10, 2022

@geido CI is done!

@geido
Copy link
Member

geido commented Feb 10, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.212.22.182:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit d409d68 into apache:master Feb 11, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants