Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve React.useRef etc. import consistency #18608

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

ad-m
Copy link
Contributor

@ad-m ad-m commented Feb 8, 2022

SUMMARY

In #18200 I received suggestion:

Can we import the useEffect from above consistently with other parts of the application?

Originally posted by @geido in #18200 (comment)

I make usage of useEffect, forwardRef, useState, useRef truly consistent in the project.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Linters & Typescript should catch up everything.

ADDITIONAL INFORMATION

  • Has associated issue: see Consistency references to useEffect, useRef etc. #18607
  • Required feature flags: N/A
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ad-m ad-m changed the title chore: improve React import reference consistency chore: improve React.useRef etc. import consistency Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #18608 (f5b1487) into master (4e2bdd4) will not change coverage.
The diff coverage is 95.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18608   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        1595     1595           
  Lines       62632    62632           
  Branches     6309     6309           
=======================================
  Hits        41529    41529           
  Misses      19453    19453           
  Partials     1650     1650           
Flag Coverage Δ
javascript 51.37% <95.23%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-table/src/DataTable/components/Pagination.tsx 3.84% <ø> (ø)
...rontend/src/components/AsyncEsmComponent/index.tsx 96.29% <92.30%> (ø)
...ntend/src/SqlLab/components/TableElement/index.tsx 72.30% <100.00%> (ø)
...t-frontend/src/components/AsyncAceEditor/index.tsx 90.90% <100.00%> (ø)
...end/src/components/IndeterminateCheckbox/index.tsx 100.00% <100.00%> (ø)
...ontend/src/components/ListViewCard/ImageLoader.tsx 88.23% <100.00%> (ø)
...set-frontend/src/components/RefreshLabel/index.tsx 100.00% <100.00%> (ø)
.../src/components/Select/WindowedSelect/windowed.tsx 70.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e2bdd4...f5b1487. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup, thanks!

@etr2460 etr2460 merged commit 7c69a1b into apache:master Feb 11, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants