-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart-data-api): download multiple csvs as zip #18618
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18618 +/- ##
=======================================
Coverage 66.30% 66.31%
=======================================
Files 1595 1595
Lines 62632 62647 +15
Branches 6309 6309
=======================================
+ Hits 41529 41545 +16
+ Misses 19453 19452 -1
Partials 1650 1650
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://52.12.219.152:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment, but since that behaviour wasn't introduced by this PR, LGTM!
Looks good, just tested! Approving :] |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
For charts that request more than one query, only the first result can be downloaded as CSV. This PR does the following:
QueryContext
returns a zip with the expected contentsQueryContext
with an emptyqueries
property, return a 400. Also add a unit test for this case.mimetype
to the pre-existing single result CSV integration testmimetype
to the pre-existing JSON download integration testBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION