Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(native filter): add test for time range filter #18647

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

jinghua-qa
Copy link
Member

SUMMARY

Add new E2E test for Native filter :'User can create a time range filter'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@jinghua-qa jinghua-qa changed the title test:add test for time range filter test(native filter): add test for time range filter Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #18647 (792341e) into master (51f716f) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18647      +/-   ##
==========================================
- Coverage   66.31%   66.25%   -0.06%     
==========================================
  Files        1595     1603       +8     
  Lines       62596    62724     +128     
  Branches     6297     6320      +23     
==========================================
+ Hits        41510    41560      +50     
- Misses      19440    19512      +72     
- Partials     1646     1652       +6     
Flag Coverage Δ
javascript 51.28% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/DataTableControl/index.tsx 74.28% <0.00%> (-23.09%) ⬇️
...et-frontend/src/explore/reducers/exploreReducer.js 25.71% <0.00%> (-7.62%) ⬇️
...re/components/controls/DatasourceControl/index.jsx 72.36% <0.00%> (-5.90%) ⬇️
.../src/dashboard/components/BuilderComponentPane.tsx 78.94% <0.00%> (-4.39%) ⬇️
.../explore/components/ExploreViewContainer/index.jsx 56.98% <0.00%> (-0.16%) ⬇️
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
superset-frontend/src/dataMask/actions.ts 72.72% <0.00%> (ø)
superset-frontend/src/dataMask/reducer.ts 50.00% <0.00%> (ø)
superset-frontend/src/dashboard/util/constants.ts 100.00% <0.00%> (ø)
superset-frontend/src/utils/localStorageHelpers.ts 90.00% <0.00%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f716f...792341e. Read the comment docs.

@jinghua-qa jinghua-qa closed this Feb 10, 2022
@jinghua-qa jinghua-qa reopened this Feb 10, 2022
@jinghua-qa jinghua-qa closed this Feb 10, 2022
@jinghua-qa jinghua-qa reopened this Feb 10, 2022
remove test id

fix lint

fix click issue

fix lint again

add force true to avoid flaky

fix failure

fix test failure

clean up code

clean up unused import

add test for time range filter

remove test id

fix lint

fix click issue

fix lint again

add force true to avoid flaky

fix failure

fix test failure
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinghua-qa jinghua-qa merged commit 7670f3a into apache:master Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io Preset-QA size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants