-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Empty states overflowing small chart containers #19095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Waiting for CI to pass for a test env
/testenv up |
I started a test env. I need to correct a test, but that won't change the functionality in any way. |
@kgabryje Ephemeral environment spinning up at http://54.188.89.111:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #19095 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1643 1645 +2
Lines 63462 63502 +40
Branches 6449 6462 +13
=======================================
+ Hits 42210 42238 +28
- Misses 19582 19590 +8
- Partials 1670 1674 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ephemeral environment shutdown and build artifacts deleted. |
* fix(dashboard): Empty states overflowing small chart containers * Fix test (cherry picked from commit 70081a6)
SUMMARY
When query returned no results, we were showing a large empty state component in chart container on the dashboard, regardless of container's size. If the container was small, the empty state was overflowing. This PR fixes that behaviour by replacing large empty state with a small one if chart's width is smaller than 300px or if chart's height is smaller than 220px.
Also, I removed chart empty state's description if it's displayed on the dashboard - the description will be displayed only on Explore page.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @kasiazjc