Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression on Select component when handling null values #19326

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

PR #19283 reintroduced an issue when handling null values in the Select component.

This PR fixes that & adds tests to catch further regressions around it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-03-23.at.08.50.12.mov

After:

Screen.Recording.2022-03-23.at.08.49.06.mov

TESTING INSTRUCTIONS

Check video for instructions

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #19326 (12fad95) into master (54c521b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19326   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files        1674     1674           
  Lines       64603    64605    +2     
  Branches     6500     6501    +1     
=======================================
+ Hits        43058    43060    +2     
  Misses      19862    19862           
  Partials     1683     1683           
Flag Coverage Δ
javascript 51.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/utils.ts 57.89% <100.00%> (+4.95%) ⬆️
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c521b...12fad95. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix and the added tests @diegomedina248!

@michael-s-molina michael-s-molina merged commit 9e58916 into apache:master Mar 23, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 23, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.11

villebro pushed a commit that referenced this pull request Apr 3, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@VladAvanyan
Copy link

Can you please tell me how to hide or ignore NULL values from native filter, or use dataset with no values even NULL ?

@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 Preset-Patch size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants