-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove TimeTable.less #19463
chore: Remove TimeTable.less #19463
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19463 +/- ##
==========================================
+ Coverage 66.57% 66.59% +0.01%
==========================================
Files 1675 1682 +7
Lines 64092 64293 +201
Branches 6519 6554 +35
==========================================
+ Hits 42672 42817 +145
- Misses 19729 19775 +46
- Partials 1691 1701 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -101,6 +100,7 @@ const defaultProps = { | |||
|
|||
const TimeTableStyles = styled.div` | |||
height: ${props => props.height}px; | |||
overflow: auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to remove the time-table class in line 328:
<TimeTableStyles className={`time-table ${className}`} height={height}>
<TimeTableStyles className={className} height={height}>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-s-molina this one as well is used by some Cypress tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the Cypress tests to query by role or an id? Leaving the class name misleads the developers when maintaining the style because they need to look for the class definition to avoid conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michael-s-molina updated
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Remove TimeTable less * Remove className * Update superset-frontend/src/visualizations/TimeTable/TimeTable.jsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
SUMMARY
Removes the TimeTable.less file from the TimeTable component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION