Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove TimeTable.less #19463

Merged
merged 3 commits into from
Apr 6, 2022
Merged

chore: Remove TimeTable.less #19463

merged 3 commits into from
Apr 6, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 31, 2022

SUMMARY

Removes the TimeTable.less file from the TimeTable component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

  1. Open a Time-series Table chart
  2. Make sure no visual changes can be observed

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #19463 (147d45b) into master (6b136c2) will increase coverage by 0.01%.
The diff coverage is 68.23%.

❗ Current head 147d45b differs from pull request most recent head b6288cd. Consider uploading reports for the commit b6288cd to get more accurate results

@@            Coverage Diff             @@
##           master   #19463      +/-   ##
==========================================
+ Coverage   66.57%   66.59%   +0.01%     
==========================================
  Files        1675     1682       +7     
  Lines       64092    64293     +201     
  Branches     6519     6554      +35     
==========================================
+ Hits        42672    42817     +145     
- Misses      19729    19775      +46     
- Partials     1691     1701      +10     
Flag Coverage Δ
javascript 51.36% <62.35%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/legacy-plugin-chart-calendar/src/Calendar.js 0.00% <ø> (ø)
...legacy-plugin-chart-calendar/src/ReactCalendar.jsx 0.00% <0.00%> (ø)
...cy-plugin-chart-calendar/src/vendor/cal-heatmap.js 0.00% <ø> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <ø> (ø)
...s/legacy-plugin-chart-heatmap/src/ReactHeatmap.jsx 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-rose/src/ReactRose.jsx 0.00% <0.00%> (ø)
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <0.00%> (ø)
...legacy-plugin-chart-sunburst/src/ReactSunburst.jsx 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js 0.00% <ø> (ø)
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b136c2...b6288cd. Read the comment docs.

@@ -101,6 +100,7 @@ const defaultProps = {

const TimeTableStyles = styled.div`
height: ${props => props.height}px;
overflow: auto;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to remove the time-table class in line 328:

<TimeTableStyles className={`time-table ${className}`} height={height}>

<TimeTableStyles className={className} height={height}>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-s-molina this one as well is used by some Cypress tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the Cypress tests to query by role or an id? Leaving the class name misleads the developers when maintaining the style because they need to look for the class definition to avoid conflicts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michael-s-molina updated

@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 4, 2022
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 73e9391 into apache:master Apr 6, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Remove TimeTable less

* Remove className

* Update superset-frontend/src/visualizations/TimeTable/TimeTable.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants