Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Filter dependencies are not being applied in default values #19698

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug where the default values of a filter were not being filtered by their dependencies.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-04-13.at.3.26.38.PM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #19698 (d6d8d1e) into master (87d4798) will increase coverage by 0.04%.
The diff coverage is 79.77%.

❗ Current head d6d8d1e differs from pull request most recent head 8a6c189. Consider uploading reports for the commit 8a6c189 to get more accurate results

@@            Coverage Diff             @@
##           master   #19698      +/-   ##
==========================================
+ Coverage   66.47%   66.51%   +0.04%     
==========================================
  Files        1681     1684       +3     
  Lines       64467    64572     +105     
  Branches     6607     6627      +20     
==========================================
+ Hits        42856    42952      +96     
- Misses      19917    19924       +7     
- Partials     1694     1696       +2     
Flag Coverage Δ
javascript 51.17% <69.81%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 35.89% <ø> (ø)
...controls/src/shared-controls/emitFilterControl.tsx 50.00% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 36.19% <ø> (ø)
...gacy-preset-chart-nvd3/src/DistBar/controlPanel.ts 11.11% <ø> (ø)
...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
...s/plugin-chart-echarts/src/BoxPlot/controlPanel.ts 100.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 100.00% <ø> (ø)
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% <ø> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.00% <0.00%> (-0.50%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.15% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d4798...8a6c189. Read the comment docs.

@michael-s-molina
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://34.222.11.132:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@michael-s-molina michael-s-molina merged commit 7bc9123 into apache:master Apr 14, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 25, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants