Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(post_processing): remove indices from csv output #19735

Closed
wants to merge 1 commit into from

Conversation

cemremengu
Copy link
Contributor

SUMMARY

This PR removes the pseudo range index added in post_processing when converting to csv.

When sending reports as csv or inline text, this id is also included. I believe it does not add any value to output however if it is somehow useful, it is better to include it either via query or make it optional.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

a

AFTER:

b

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

This PR removes the pseudo range index  added in post_processing when converting to csv. 

When sending reports as csv or inline text, this id is also included. I believe it does not add any value to output however if it is somehow useful, it is better to include it either via query or make it optional.
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #19735 (11d1bbf) into master (b7759e6) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #19735      +/-   ##
==========================================
+ Coverage   66.48%   66.51%   +0.02%     
==========================================
  Files        1686     1686              
  Lines       64588    64585       -3     
  Branches     6636     6636              
==========================================
+ Hits        42942    42958      +16     
+ Misses      19947    19928      -19     
  Partials     1699     1699              
Flag Coverage Δ
hive 52.70% <0.00%> (+<0.01%) ⬆️
mysql 81.96% <0.00%> (+<0.01%) ⬆️
postgres 82.01% <0.00%> (?)
presto 52.54% <0.00%> (+<0.01%) ⬆️
python 82.43% <0.00%> (+0.05%) ⬆️
sqlite 81.77% <0.00%> (+<0.01%) ⬆️
unit 47.76% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/post_processing.py 68.75% <0.00%> (+1.57%) ⬆️
superset/reports/commands/execute.py 91.51% <0.00%> (+0.36%) ⬆️
superset/views/base_api.py 98.31% <0.00%> (+0.42%) ⬆️
superset/common/query_object.py 95.26% <0.00%> (+0.52%) ⬆️
superset/commands/importers/v1/utils.py 93.50% <0.00%> (+1.29%) ⬆️
superset/db_engine_specs/postgres.py 97.27% <0.00%> (+1.81%) ⬆️
superset/reports/commands/log_prune.py 89.28% <0.00%> (+3.57%) ⬆️
superset/sql_validators/postgres.py 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7759e6...11d1bbf. Read the comment docs.

@cemremengu cemremengu changed the title refactor(post_processing)!: remove indices from csv output refactor!(post_processing): remove indices from csv output Apr 15, 2022
@cemremengu cemremengu changed the title refactor!(post_processing): remove indices from csv output refactor(post_processing): remove indices from csv output Apr 15, 2022
@cemremengu cemremengu changed the title refactor(post_processing): remove indices from csv output fix(post_processing): remove indices from csv output Apr 22, 2022
@cemremengu cemremengu closed this Apr 26, 2022
@cemremengu cemremengu deleted the patch-8 branch April 26, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant