fix: Add locale for DatePicker component #20063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
reviewed
May 14, 2022
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx
Outdated
Show resolved
Hide resolved
aehanno
changed the title
|
Hello @zhaoyongjie, just to know if you got time to check on my changes |
|
@aehanno Sorry for the waiting. I will review PR tomorrow. Thanks for your patience. |
|
Hi @zhaoyongjie any news on this PR ? |
|
Hi @zhaoyongjie is it possible to review this PR ? Thank you ! |
|
triggering CI |
|
Hi @nytai we pushed a correction, is it possible to trigger CI ? |
|
Hi @mathieudruart, Thank you for the patient. I have pushed a branch to the repo base on your current branch, you should just 1) rebase the master branch 2) cheery-pick the latest commit to this for unblocking the CI. |
kevin-kosmos
requested review from
jinghua-qa,
craig-rueda,
dpgaspar,
villebro and
michael-s-molina
as code owners
kevin-kosmos
force-pushed
the
add-translation-for-DatePicker
branch
from
b5588f5
to
0404d90
Compare
Codecov Report
@@ Coverage Diff @@
## master #20063 +/- ##
=======================================
Coverage 66.58% 66.58%
=======================================
Files 1790 1790
Lines 68416 68419 +3
Branches 7287 7287
=======================================
+ Hits 45554 45556 +2
Misses 20986 20986
- Partials 1876 1877 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhaoyongjie
approved these changes
Sep 7, 2022
zhaoyongjie
changed the title
eschutho
pushed a commit
that referenced
this pull request
Sep 27, 2022
Co-authored-by: Kevin Dethelot <kevin.dethelot@kosmos.fr> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
AAfghahi
pushed a commit
that referenced
this pull request
Oct 5, 2022
Co-authored-by: Kevin Dethelot <kevin.dethelot@kosmos.fr> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
AAfghahi
pushed a commit
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Kevin Dethelot <kevin.dethelot@kosmos.fr> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
Fahrenheit35
pushed a commit
to Fahrenheit35/superset
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Kevin Dethelot <kevin.dethelot@kosmos.fr> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
mistercrunch
added
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding french translation for DatePicker component
ADDITIONAL INFORMATION
fix #20062