-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move xaxis to superset-ui #20438
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20438 +/- ##
=======================================
Coverage 66.71% 66.71%
=======================================
Files 1739 1738 -1
Lines 65161 65162 +1
Branches 6899 6895 -4
=======================================
+ Hits 43469 43474 +5
Misses 19939 19939
+ Partials 1753 1749 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
In order to backward-compatible NVD3 chart,
superset-ui
.echarts plugins
move constants intoconstats.ts
from 'type.ts`.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No functional changes.
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION