-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove legacy treemap/area #20639
Conversation
@zhaoyongjie are we 100% sure these are unused? If not it seems like a migration would be necessary conditional on the fact that parity exists between the old NVD3 and new ECharts charts. |
4413c68
to
5337aad
Compare
@john-bodley thanks for the tip, I updated PR, and the legacy plugins were been kept. when the PR is merged, I will turn this open. |
5337aad
to
6cf1c91
Compare
Codecov Report
@@ Coverage Diff @@
## master #20639 +/- ##
=======================================
Coverage 66.79% 66.79%
=======================================
Files 1754 1754
Lines 65874 65862 -12
Branches 7030 7030
=======================================
- Hits 43999 43994 -5
+ Misses 20086 20079 -7
Partials 1789 1789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Remove unused viz-plugins
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION