-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: datasourcedao datasource not found error #20725
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20725 +/- ##
==========================================
- Coverage 66.30% 66.11% -0.20%
==========================================
Files 1756 1756
Lines 66734 66737 +3
Branches 7049 7049
==========================================
- Hits 44248 44121 -127
- Misses 20689 20819 +130
Partials 1797 1797
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ix-datasourcedao-error
@@ -815,7 +815,7 @@ def explore( | |||
try: | |||
datasource = DatasourceDAO.get_datasource( | |||
db.session, | |||
DatasourceType(cast(str, datasource_type)), | |||
DatasourceType("table"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SUMMARY
This pr is a possible fix for potential error of having the wrong type for the datasource type and causing a validation error being thrown.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION