-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Feature flag for embedding charts #20804
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20804 +/- ##
==========================================
+ Coverage 66.29% 66.34% +0.04%
==========================================
Files 1758 1756 -2
Lines 66801 66749 -52
Branches 7055 7060 +5
==========================================
- Hits 44288 44284 -4
+ Misses 20713 20667 -46
+ Partials 1800 1798 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/testenv up FEATURE_EMBEDDABLE_CHARTS=false |
@geido Ephemeral environment spinning up at http://34.214.222.137:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Users of Superset might not want to give the ability to embed charts, especially as embedding uses iFrames that might be disabled for security reasons. This PR adds a
EMBEDDABLE_CHARTS
flag to the config to enable/disable embedding charts. Default toTrue
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Set the feature flag off and make sure the Embed code option isn't appearing as a Share option in Explore.
ADDITIONAL INFORMATION