Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add SAMPLES_ROW_LIMIT in frontend conf #20841

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Let the frontend knows what is SAMPLES_ROW_LIMIT value.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

The redux of explore or dashboard should access this config item.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #20841 (c52192d) into master (9bf7ed5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20841   +/-   ##
=======================================
  Coverage   66.33%   66.33%           
=======================================
  Files        1756     1756           
  Lines       66769    66769           
  Branches     7059     7059           
=======================================
  Hits        44288    44288           
  Misses      20684    20684           
  Partials     1797     1797           
Flag Coverage Δ
hive 53.25% <ø> (ø)
mysql 81.06% <ø> (ø)
postgres 81.13% <ø> (ø)
presto 53.11% <ø> (ø)
python 81.57% <ø> (ø)
sqlite 79.74% <ø> (ø)
unit 50.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 75.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit 644148b into apache:master Jul 25, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants