Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removing erroneous FAQ timeout message #20853

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR removes an erroneous entry in the FAQ regarding timeouts. Firstly the superset runserver command doesn't exist, and secondly the guicorn timeout (which isn't explicitly mentioned but possibly inferred) is related to the timeout of idle workers rather than web requests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #20853 (ebc3f58) into master (e3c6380) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20853   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        1757     1757           
  Lines       66860    66860           
  Branches     7077     7077           
=======================================
  Hits        44332    44332           
  Misses      20719    20719           
  Partials     1809     1809           
Flag Coverage Δ
hive 53.26% <ø> (ø)
javascript 51.95% <ø> (ø)
mysql 81.07% <ø> (ø)
postgres 81.15% <ø> (ø)
presto 53.12% <ø> (ø)
python 81.59% <ø> (ø)
sqlite 79.76% <ø> (ø)
unit 50.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rusackas rusackas merged commit f86e99e into master Sep 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the john-bodley--update-faq-docs branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants