Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change Sort-by and Sort-Descending controls for Bar Chart v2 #20868

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

Two changes on time series bar v2:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #20868 (e38ebdc) into master (ce19741) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head e38ebdc differs from pull request most recent head 1d9bd60. Consider uploading reports for the commit 1d9bd60 to get more accurate results

@@            Coverage Diff             @@
##           master   #20868      +/-   ##
==========================================
- Coverage   66.27%   66.26%   -0.01%     
==========================================
  Files        1757     1757              
  Lines       66954    66958       +4     
  Branches     7107     7109       +2     
==========================================
  Hits        44372    44372              
- Misses      20767    20771       +4     
  Partials     1815     1815              
Flag Coverage Δ
javascript 51.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 31.25% <0.00%> (-4.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rusackas rusackas merged commit 7beda3b into apache:master Aug 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants