chore: add test for tab state #20949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20949 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 1766 1766
Lines 67224 67224
Branches 7135 7135
=======================================
+ Hits 44625 44630 +5
+ Misses 20774 20769 -5
Partials 1825 1825
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AAfghahi
approved these changes
Aug 10, 2022
| @@ -1468,6 +1468,38 @@ def test_sqllab_backend_persistence_payload(self): | |||
| payload = views.Superset._get_sqllab_tabs(user_id=user_id) | |||
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for #20947 which was a fix for breaking cypress tests on CI.
We wanted to make sure that both params were allowed by the api (name and title) for backward compatibility
ADDITIONAL INFORMATION