Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing cache timeout setting #210

Closed
wants to merge 2 commits into from

Conversation

sid88in
Copy link
Contributor

@sid88in sid88in commented Mar 29, 2016

the current v0.8.4 fails if the cache timeout setting on the UI is not provided in edit datasource settings view: http://hostname:port/druiddatasourcemodelview/list/

self.cache_timeout causes the exception. The new logic is as follows:

  1. try to find the cache timeout value from the UI
  2. If not then get the default value in the caravel_config.py
  3. If the value is not defined in both config and the UI then set it to 0.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.25% when pulling c8b76f1 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 71.078% when pulling c8b76f1 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling e04f212 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 71.047% when pulling e04f212 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@mistercrunch
Copy link
Member

Mmmh, some of that logic is already here:
https://github.com/sid88in/caravel/blob/fix_attribute_error/caravel/viz.py#L217

What kind of stack trace were you getting?

@sid88in
Copy link
Contributor Author

sid88in commented Mar 29, 2016

@mistercrunch I have added my stack trace here: #207

@mistercrunch
Copy link
Member

It's been addressed in another PR, thanks for the PR though!

graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants