fix(plugin-chart-table): Upgrade old color formats #21101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
First version of table conditional formatter was using
rgb()
format to describe colors. Later we changed it to hex notation, which broke the existing color formatters. This PR adds a migration of old color formatters to use hex notation.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
rgb(255,0,0)
for red,rgb(255,255,0)
for yellow orrgb(0,255,0)
for green.ADDITIONAL INFORMATION
Current: 0.56 s
10+: 0.85 s
100+: 0.64 s
1000+: 0.54 s