Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug when loading DruidDatasource. #213

Merged
merged 3 commits into from
Mar 31, 2016
Merged

Fix a bug when loading DruidDatasource. #213

merged 3 commits into from
Mar 31, 2016

Conversation

coleslaw
Copy link
Contributor

A bug is introduced in this commit

https://github.com/airbnb/caravel/pull/188/files#diff-ba3aebfb9fa5aadd492450873088cd15R222

caused this error when viewing DruidDatasource.

screenshot 2016-03-30 16 13 30

@mistercrunch @hongbozeng

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling f67c6b5 on airbnb:kim/fix_druid_datasource_bug into fd40742 on airbnb:master.

@hongbozeng
Copy link

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.175% when pulling f67c6b5 on kim/fix_druid_datasource_bug into fd40742 on master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.13% when pulling 4a77b70 on kim/fix_druid_datasource_bug into fd40742 on master.

hongbozeng
hongbozeng reviewed Mar 30, 2016
View reviewed changes
caravel/viz.py
if self.datasource.cache_timeout:
return self.datasource.cache_timeout
if hasattr(self.datasource, 'database') \
and self.datasource.database.cache_timeout:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not put on the previous line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It exceeds the line limit, which Max set to be 90 @hongbozeng

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.04% when pulling e598e28 on kim/fix_druid_datasource_bug into fd40742 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 71.139% when pulling e598e2867d23369ecb539e5d1fb0daac044acfc3 on kim/fix_druid_datasource_bug into fd40742 on master.

@coleslaw coleslaw force-pushed the kim/fix_druid_datasource_bug branch from e598e28 to e5553ab Compare March 30, 2016 23:38
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling e5553ab on airbnb:kim/fix_druid_datasource_bug into fd40742 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 71.139% when pulling e5553ab on kim/fix_druid_datasource_bug into fd40742 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 71.139% when pulling e5553ab on kim/fix_druid_datasource_bug into fd40742 on master.

@mistercrunch mistercrunch merged commit 5b7fe2b into master Mar 31, 2016
@mistercrunch mistercrunch deleted the kim/fix_druid_datasource_bug branch March 31, 2016 00:02
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
@dependabot-preview @kristw
build(deps): update @superset-ui/legacy-preset-chart-big-number requi…
8baede4 
…rement (apache#213)

Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version.
- [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases)
- [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md)
- [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @superset-ui/legacy-preset-chart-big-number requi…
6fc32d7 
…rement (apache#213)

Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version.
- [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases)
- [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md)
- [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @data-ui/event-flow requirement (apache#213)
42be358 
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.80...v0.0.81)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @superset-ui/legacy-preset-chart-big-number requi…
b050a3c 
…rement (apache#213)

Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version.
- [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases)
- [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md)
- [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @data-ui/event-flow requirement (apache#213)
68c6711 
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.80...v0.0.81)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @superset-ui/legacy-preset-chart-big-number requi…
73c7716 
…rement (apache#213)

Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version.
- [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases)
- [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md)
- [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @data-ui/event-flow requirement (apache#213)
816ccfa 
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.80...v0.0.81)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @superset-ui/legacy-preset-chart-big-number requi…
3138aaa 
…rement (apache#213)

Updates the requirements on [@superset-ui/legacy-preset-chart-big-number](https://github.com/apache-superset/superset-ui-plugins) to permit the latest version.
- [Release notes](https://github.com/apache-superset/superset-ui-plugins/releases)
- [Changelog](https://github.com/apache-superset/superset-ui-plugins/blob/master/CHANGELOG.md)
- [Commits](apache-superset/superset-ui-plugins@v0.10.0...v0.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@dependabot-preview @zhaoyongjie
build(deps): update @data-ui/event-flow requirement (apache#213)
e69fc44 
Updates the requirements on [@data-ui/event-flow](https://github.com/williaster/data-ui) to permit the latest version.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.80...v0.0.81)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@snyk-bot snyk-bot mentioned this pull request Dec 13, 2021
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@coleslaw @landscape-bot @hongbozeng @coveralls @mistercrunch @kim-pham-airbnb