chore(tags): Refactor logic to leverage Flask-SQLAlchemy extension #21459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rather than passing in the
engine
—which isn't apparent whether it refers to an external engine or Superset's metadata engine—when managing tags, this PR simply leverages the Flask-SQLAlchemy extension directly.Note it's not overly clear whether we should use
db.engine.execute(...)
ordb.session.execute(...)
, though per here it seems like the later is preferred when using the ORM functionality (as opposed to raw SQL).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION