Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Unpin sqlparse dependency #21581

Merged
merged 3 commits into from
Sep 26, 2022
Merged

chore(deps): Unpin sqlparse dependency #21581

merged 3 commits into from
Sep 26, 2022

Conversation

ecederstrand
Copy link
Contributor

@ecederstrand ecederstrand commented Sep 26, 2022

SUMMARY

The blocking issue has been fixed upstream. Bump sqlparse to version 0.4.3. Change suggested in discussion #21580

@ecederstrand ecederstrand changed the title Bump sqlparse to version 0.4.3 containing required bug fix Unpin sqlparse dependency Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #21581 (79073ce) into master (5d51555) will decrease coverage by 1.32%.
The diff coverage is 42.85%.

❗ Current head 79073ce differs from pull request most recent head 4808af0. Consider uploading reports for the commit 4808af0 to get more accurate results

@@            Coverage Diff             @@
##           master   #21581      +/-   ##
==========================================
- Coverage   66.65%   65.33%   -1.33%     
==========================================
  Files        1794     1794              
  Lines       68692    68692              
  Branches     7308     7308              
==========================================
- Hits        45789    44879     -910     
- Misses      21035    21945     +910     
  Partials     1868     1868              
Flag Coverage Δ
hive 52.89% <ø> (ø)
mysql 78.21% <ø> (ø)
postgres ?
presto 52.79% <ø> (ø)
python 78.68% <ø> (-2.74%) ⬇️
sqlite 76.78% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...chart-controls/src/shared-controls/dndControls.tsx 53.57% <ø> (ø)
...src/BigNumber/BigNumberWithTrendline/buildQuery.ts 0.00% <0.00%> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 25.00% <ø> (ø)
...i-chart-controls/src/shared-controls/constants.tsx 33.33% <50.00%> (ø)
...BigNumber/BigNumberWithTrendline/transformProps.ts 46.26% <66.66%> (ø)
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
... and 67 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ecederstrand ecederstrand changed the title Unpin sqlparse dependency chore(deps): Unpin sqlparse dependency Sep 26, 2022
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, AWESOME work @ecederstrand , thanks for fixing this upstream! 🎉 One minor note

setup.py Outdated Show resolved Hide resolved
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Again, HUGE thanks for the upstream change 👏

@ecederstrand
Copy link
Contributor Author

You're welcome :-)

@villebro villebro merged commit 82bd5a3 into apache:master Sep 26, 2022
@ecederstrand ecederstrand deleted the bump-sqlparse-dep branch September 26, 2022 19:46
@john-bodley
Copy link
Member

Thanks @ecederstrand. I was just about to make this change after realizing that the blocking issue had been fixed as our current version wasn't removing backticks per the sqlparse.utils.remove_quotes method.

john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Oct 6, 2022
Co-authored-by: Erik Cederstrand <erik@adamatics.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
(cherry picked from commit 82bd5a3)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants