-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Unpin sqlparse dependency #21581
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21581 +/- ##
==========================================
- Coverage 66.65% 65.33% -1.33%
==========================================
Files 1794 1794
Lines 68692 68692
Branches 7308 7308
==========================================
- Hits 45789 44879 -910
- Misses 21035 21945 +910
Partials 1868 1868
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, AWESOME work @ecederstrand , thanks for fixing this upstream! 🎉 One minor note
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Again, HUGE thanks for the upstream change 👏
You're welcome :-) |
Thanks @ecederstrand. I was just about to make this change after realizing that the blocking issue had been fixed as our current version wasn't removing backticks per the |
Co-authored-by: Erik Cederstrand <erik@adamatics.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> (cherry picked from commit 82bd5a3)
SUMMARY
The blocking issue has been fixed upstream. Bump sqlparse to version 0.4.3. Change suggested in discussion #21580