Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): Add tests for getControlValuesCompatibleWithDatasource #21744

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Oct 8, 2022

SUMMARY

PR #21544 was a fix for something I broke in #21315. This PR adds unit tests for the getControlValuesCompatibleWithDatasource module, used when the datasource is switched in Explore to keep valid control values, that would have caught this bug.

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #21744 (ed9ae36) into master (200bed6) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21744      +/-   ##
==========================================
+ Coverage   66.83%   66.86%   +0.02%     
==========================================
  Files        1800     1800              
  Lines       68937    68943       +6     
  Branches     7335     7335              
==========================================
+ Hits        46077    46100      +23     
+ Misses      20967    20946      -21     
- Partials     1893     1897       +4     
Flag Coverage Δ
javascript 53.21% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/hooks.ts 46.39% <0.00%> (-0.17%) ⬇️
superset-frontend/src/explore/ExplorePage.tsx 0.00% <0.00%> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 55.73% <0.00%> (+0.06%) ⬆️
superset-frontend/src/SqlLab/actions/sqlLab.js 63.04% <0.00%> (+0.38%) ⬆️
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 54.70% <0.00%> (+0.46%) ⬆️
...lUtils/getControlValuesCompatibleWithDatasource.ts 80.00% <0.00%> (+72.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 070b865 into apache:master Oct 11, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants