-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump react-map-gl from 4.0.10 to 6.1.19 #21748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21748 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 1800 1800
Lines 68951 68951
Branches 7335 7335
=======================================
Hits 46092 46092
- Misses 20965 20966 +1
+ Partials 1894 1893 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@zhaoyongjie Ephemeral environment spinning up at http://34.222.28.62:8080. Credentials are |
@stephenLYZ Can we try to update Version 6 - 1.81 MBVersion 7 - 410 kB |
Yeah. The main chart involved is mapbox, which will probably be rewritten in version 7. Let's do it in the another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Since there is "Prototype Pollution" in minimist(< 1.2.6), we need to upgrade to 1.2.6. Currently we have two dependecy chains:
So just upgrading react-map-gl and mapbox-gl can resolve the issue. However, react-map-gl has break change in version 7 (https://visgl.github.io/react-map-gl/docs/upgrade-guide), we upgrade to version 6 to avoid major changes。
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION