fix(CustomFrame): Resolves issue #21731 where date range in explore throws runtime error #21776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e error when explore.common is undefined in Redux state Changes made in superset/superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx in PR https://github.com/apache/superset/pull/20063/files#diff-ac08ce133d14a8a92607bf02bc368b6b52b8314ddef1b872e42746ba8d6038d0 introduced bug that expects redux state to contain a path that is undefined
eschutho
reviewed
Oct 11, 2022
|
|
||
| // case when common.locale is populated with invalid locale | ||
| const mockInvalidStore = configureStore([thunk]); | ||
| const invalidStore = mockInvalidStore({ common: { locale: 'invalid_locale' } }); |
There was a problem hiding this comment.
I'm not familiar with the return object of configureStore but can you create two separate distinct stores with the same return of configureStore? In other words, can we create empty and invalid both from the mockEmptyStore?
There was a problem hiding this comment.
Great catch! I was able to consolidate one call to configureStore, and reuse calls to mockStore with the different values.
eschutho
approved these changes
Oct 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #21776 +/- ##
==========================================
- Coverage 66.88% 66.86% -0.02%
==========================================
Files 1802 1803 +1
Lines 68987 68997 +10
Branches 7345 7349 +4
==========================================
- Hits 46139 46134 -5
- Misses 20951 20971 +20
+ Partials 1897 1892 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhaoyongjie
approved these changes
Oct 13, 2022
Fahrenheit35
pushed a commit
to Fahrenheit35/superset
that referenced
this pull request
Nov 11, 2022
…lore throws runtime error (apache#21776)
AAfghahi
pushed a commit
that referenced
this pull request
Nov 21, 2022
…hrows runtime error (#21776)
AAfghahi
pushed a commit
that referenced
this pull request
Dec 15, 2022
…hrows runtime error (#21776)
mistercrunch
added
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Resolves issue #21731 where date range in explore throws runtime error when explore.common is undefined in Redux state.
See associated issue: #21731
This issue is reproducible from the 2.0.0 and 2.0.1 RC1 releases but the change also improves runtime resilience of master. PR is targeting master, but intended to be cherry picked into the 2.0.1 RC1 as well.
Changes made in superset/superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx
in PR https://github.com/apache/superset/pull/20063/files#diff-ac08ce133d14a8a92607bf02bc368b6b52b8314ddef1b872e42746ba8d6038d0
introduced a bug that expects redux state to contain a path that may be undefined, and assume that a provided locale is valid and known by antd. This fix ensures safety checks are made and that antd DatePicker can fall back to internal default is a compatible locale is not identified.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See associated issue: #21731
TESTING INSTRUCTIONS
See associated issue: #21731
ADDITIONAL INFORMATION