Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression in #21766 #21782

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

fix a regression was introduced by #21766

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #21782 (d629edd) into master (8f61e3c) will not change coverage.
The diff coverage is n/a.

❗ Current head d629edd differs from pull request most recent head 09d13d0. Consider uploading reports for the commit 09d13d0 to get more accurate results

@@           Coverage Diff           @@
##           master   #21782   +/-   ##
=======================================
  Coverage   66.86%   66.86%           
=======================================
  Files        1803     1803           
  Lines       68996    68996           
  Branches     7349     7349           
=======================================
  Hits        46132    46132           
  Misses      20971    20971           
  Partials     1893     1893           
Flag Coverage Δ
javascript 53.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/explore/reducers/exploreReducer.js 37.50% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie merged commit 8f74e46 into apache:master Oct 12, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants