-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: E2E Dashboards Cross-references #21805
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21805 +/- ##
==========================================
+ Coverage 65.65% 66.90% +1.24%
==========================================
Files 1806 1806
Lines 69130 69130
Branches 7391 7391
==========================================
+ Hits 45390 46249 +859
+ Misses 21829 20970 -859
Partials 1911 1911
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…e/e2e-cross-references
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the tests @geido!
superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/chart_list/list.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/cypress-base/cypress/integration/explore/chart.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Adds E2E tests for cross-referenced Dashboards in Charts list and Explore. Filtering was already tested in the original PR.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION