Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqla): refactor query utils #21811

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

villebro
Copy link
Member

SUMMARY

Refactor a few query utils and add missing tests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar self-requested a review October 14, 2022 08:57
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #21811 (6960d68) into master (df3b5a8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21811      +/-   ##
==========================================
+ Coverage   66.85%   66.86%   +0.01%     
==========================================
  Files        1805     1805              
  Lines       69061    69074      +13     
  Branches     7369     7369              
==========================================
+ Hits        46169    46186      +17     
+ Misses      20995    20991       -4     
  Partials     1897     1897              
Flag Coverage Δ
hive 52.92% <75.00%> (+<0.01%) ⬆️
mysql 78.35% <100.00%> (+0.10%) ⬆️
postgres 78.41% <100.00%> (+0.10%) ⬆️
presto 52.82% <75.00%> (+<0.01%) ⬆️
python 81.47% <100.00%> (+0.01%) ⬆️
sqlite 76.90% <100.00%> (+0.10%) ⬆️
unit 51.06% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 91.01% <100.00%> (+0.27%) ⬆️
superset/security/manager.py 95.75% <0.00%> (ø)
superset/reports/commands/execute.py 91.98% <0.00%> (ø)
superset/reports/api.py 90.29% <0.00%> (+0.07%) ⬆️
superset/sqllab/command.py 84.00% <0.00%> (+0.12%) ⬆️
superset/reports/dao.py 84.92% <0.00%> (+0.24%) ⬆️
superset/connectors/sqla/utils.py 90.19% <0.00%> (+0.98%) ⬆️
superset/reports/filters.py 95.23% <0.00%> (+2.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 52d33b0 into apache:master Oct 17, 2022
AAfghahi pushed a commit that referenced this pull request Nov 1, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
@villebro villebro deleted the villebro/adhoc-filter-subquery branch November 2, 2022 12:25
eschutho pushed a commit that referenced this pull request Nov 2, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
AAfghahi pushed a commit that referenced this pull request Nov 17, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
AAfghahi pushed a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
AAfghahi pushed a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
AAfghahi pushed a commit that referenced this pull request Dec 15, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
AAfghahi pushed a commit that referenced this pull request Dec 15, 2022
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
michael-s-molina pushed a commit that referenced this pull request Jan 5, 2023
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
@mistercrunch mistercrunch added 🍒 1.5.3 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v1.5 v2.0 v2.0.1 🍒 1.5.3 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants