Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added translate functions #21816

Merged
merged 2 commits into from
Oct 19, 2022
Merged

chore: Added translate functions #21816

merged 2 commits into from
Oct 19, 2022

Conversation

AndVK
Copy link
Contributor

@AndVK AndVK commented Oct 14, 2022

SUMMARY

Added translate functions

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@stephenLYZ stephenLYZ changed the title Added translate functions chore: Added translate functions Oct 15, 2022
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #21816 (cdc0d97) into master (2c7323a) will increase coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #21816      +/-   ##
==========================================
+ Coverage   66.66%   66.82%   +0.15%     
==========================================
  Files        1791     1804      +13     
  Lines       68498    68843     +345     
  Branches     7286     7369      +83     
==========================================
+ Hits        45666    46003     +337     
+ Misses      20962    20933      -29     
- Partials     1870     1907      +37     
Flag Coverage Δ
javascript 53.29% <66.66%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <ø> (ø)
...i-chart-controls/src/sections/forecastInterval.tsx 100.00% <ø> (ø)
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 100.00% <ø> (ø)
...-chart-nvd3/src/vendor/superset/AnnotationTypes.js 71.42% <ø> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <ø> (-8.34%) ⬇️
...tend/plugins/plugin-chart-echarts/src/controls.tsx 72.72% <ø> (ø)
...lugins/plugin-chart-handlebars/src/plugin/index.ts 66.66% <ø> (ø)
...tend/src/components/Datasource/DatasourceModal.tsx 69.76% <ø> (ø)
... and 199 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement!

@stephenLYZ stephenLYZ merged commit df7840c into apache:master Oct 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants