Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type of AnnotationLayer #21878

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

justinpark
Copy link
Member

SUMMARY

This commit fixes the type of AnnotationLayer to be compatible with TableAnnotationLayer
This will be thrown an error in next typescript version.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-10-19 at 2 31 09 PM

TESTING INSTRUCTIONS

bump up typescript to 4.6.4 and then npm run type

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #21878 (2716e76) into master (54f6fd6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21878      +/-   ##
==========================================
- Coverage   66.90%   66.90%   -0.01%     
==========================================
  Files        1805     1806       +1     
  Lines       69081    69129      +48     
  Branches     7378     7391      +13     
==========================================
+ Hits        46218    46248      +30     
- Misses      20953    20970      +17     
- Partials     1910     1911       +1     
Flag Coverage Δ
javascript 53.29% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-ui-core/src/query/types/AnnotationLayer.ts 100.00% <ø> (ø)
...frontend/src/components/Chart/ChartContextMenu.tsx 11.53% <0.00%> (-32.47%) ⬇️
...et-frontend/src/components/Chart/ChartRenderer.jsx 51.25% <0.00%> (-2.18%) ⬇️
...ins/plugin-chart-table/src/DataTable/DataTable.tsx 38.46% <0.00%> (-0.34%) ⬇️
superset-frontend/src/components/Chart/Chart.jsx 51.66% <0.00%> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-world-map/src/index.js 66.66% <0.00%> (ø)
...dashboard/components/SliceHeaderControls/index.tsx 70.21% <0.00%> (ø)
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit f4a4ab4 into apache:master Oct 21, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants