Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small bump to shillelagh #21953

Conversation

AAfghahi
Copy link
Member

SUMMARY

There were some edge cases in gsheets which required a new shillelagh release. This bump the min requirement in setup.py. Since shillelagh is not a required install it will not change requirements.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #21953 (30f2674) into master (9a063ab) will increase coverage by 11.80%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #21953       +/-   ##
===========================================
+ Coverage   55.55%   67.35%   +11.80%     
===========================================
  Files        1806     1806               
  Lines       69140    70201     +1061     
  Branches     7393     7393               
===========================================
+ Hits        38409    47286     +8877     
+ Misses      28822    21006     -7816     
  Partials     1909     1909               
Flag Coverage Δ
hive 53.35% <ø> (+0.42%) ⬆️
javascript 53.31% <ø> (ø)
mysql 78.86% <ø> (?)
postgres 78.92% <ø> (?)
presto 53.25% <ø> (+0.42%) ⬆️
python 81.93% <ø> (+23.98%) ⬆️
sqlite 77.39% <ø> (?)
unit 51.64% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.64% <0.00%> (+0.59%) ⬆️
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
superset/sql_parse.py 96.49% <0.00%> (+1.16%) ⬆️
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) ⬆️
superset/tables/models.py 67.53% <0.00%> (+1.29%) ⬆️
superset/exceptions.py 90.43% <0.00%> (+1.73%) ⬆️
superset/reports/models.py 100.00% <0.00%> (+2.00%) ⬆️
superset/explore/utils.py 100.00% <0.00%> (+2.27%) ⬆️
superset/datasets/commands/importers/v1/utils.py 58.33% <0.00%> (+2.38%) ⬆️
superset/sql_lab.py 82.12% <0.00%> (+3.04%) ⬆️
... and 283 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AAfghahi AAfghahi merged commit 102909e into master Oct 27, 2022
@AAfghahi AAfghahi deleted the arash.afghahi/sc-55039/gsheet-number-format-removes-all-zero-after branch October 27, 2022 22:08
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants