-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adds logging for SPA route navigation with React router #21960
fix: Adds logging for SPA route navigation with React router #21960
Conversation
… loggerMiddleware that was sending malformed log payloads in some cases
Codecov Report
@@ Coverage Diff @@
## master #21960 +/- ##
==========================================
- Coverage 66.86% 66.85% -0.01%
==========================================
Files 1807 1807
Lines 69218 69221 +3
Branches 7402 7402
==========================================
+ Hits 46280 46281 +1
- Misses 21033 21035 +2
Partials 1905 1905
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -26,9 +26,9 @@ class DebouncedMessageQueue { | |||
}) { | |||
this.queue = []; | |||
this.sizeThreshold = sizeThreshold; | |||
this.delayThrehold = delayThreshold; | |||
this.delayThreshold = delayThreshold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
Adds logging for SPA route navigation with React router, fixes bug in loggerMiddleware that was sending malformed log payloads in some cases
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
SPA.Nav.Logging.mov
TESTING INSTRUCTIONS
SELECT * from logs ORDER BY dttm DESC
ADDITIONAL INFORMATION