feat(ssh_tunnel): DAO Changes for SSH Tunnel #22120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New DAO Class for SSH Tunnel - Add method to fetch related ssh tunnel in the DatabaseDAO
hughhhh
reviewed
Nov 15, 2022
superset/databases/dao.py
Outdated
| @@ -124,3 +125,13 @@ def get_related_objects(cls, database_id: int) -> Dict[str, Any]: | |||
| return dict( | |||
| charts=charts, dashboards=dashboards, sqllab_tab_states=sqllab_tab_states | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def get_related_ssh_tunnel(cls, database_id: int) -> Dict[str, Any]: | |||
There was a problem hiding this comment.
let's just call the get_ssh_tunnel since it's a 1 to 1 relationship
There was a problem hiding this comment.
Cool! Renamed to get_ssh_tunnel 👍
- Rename method since it's a 1:1 relationship
hughhhh
reviewed
Nov 15, 2022
| @@ -124,3 +125,13 @@ def get_related_objects(cls, database_id: int) -> Dict[str, Any]: | |||
| return dict( | |||
| charts=charts, dashboards=dashboards, sqllab_tab_states=sqllab_tab_states | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def get_ssh_tunnel(cls, database_id: int) -> Dict[str, Any]: | |||
There was a problem hiding this comment.
also can we write a small unit test for this here's an example
- Add Unit Tests for our new method in the DatabaseDAO
hughhhh
approved these changes
Nov 15, 2022
15 tasks
Antonio-RiveroMartnez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION