-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SQLite dttm ISO format #22128
fix: SQLite dttm ISO format #22128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22128 +/- ##
==========================================
- Coverage 66.98% 66.93% -0.06%
==========================================
Files 1832 1832
Lines 69918 69918
Branches 7570 7570
==========================================
- Hits 46838 46802 -36
- Misses 21122 21158 +36
Partials 1958 1958
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6fc4e05
to
d51b0b6
Compare
@@ -82,7 +82,7 @@ def convert_dttm( | |||
utils.TemporalType.DATETIME, | |||
utils.TemporalType.TIMESTAMP, | |||
): | |||
return f"""'{dttm.isoformat(sep=" ", timespec="seconds")}'""" | |||
return f"""'{dttm.isoformat(sep=" ", timespec="microseconds")}'""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing this in favor of #22170. |
SUMMARY
Fix SQLite
dttm
ISO format to usemicroseconds
as thetimespec
. This resolves a bug when comparingdttm
values withDATETIME
andTIMESTAMP
columns on SQLite.TESTING INSTRUCTIONS
There's a unit test for this function. All tests should pass.
ADDITIONAL INFORMATION