feat(ssh_tunnel): Delete command & exceptions #22131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Delete Command and its exceptions
Antonio-RiveroMartnez
force-pushed
the
delete_command_exception
branch
from
57ef095
to
2edb163
Compare
hughhhh
reviewed
Nov 16, 2022
| self._model_id = model_id | ||
| self._model: Optional[SSHTunnel] = None | ||
|
|
||
| def run(self) -> Model: |
There was a problem hiding this comment.
can we write a small unit test for deleting this the same way as the last PR we have
There was a problem hiding this comment.
Oh yeah! Let me add those for this and the update one
hughhhh
reviewed
Nov 16, 2022
|
|
||
|
|
||
| class SSHTunnelDeleteFailedError(DeleteFailedError): | ||
| message = _("SSH Tunnel could not be deleted.") |
There was a problem hiding this comment.
can you add a status 500 on this one
There was a problem hiding this comment.
The parent class already has status = 500 so it should be already there.
hughhhh
reviewed
Nov 16, 2022
| message = _("SSH Tunnel could not be deleted.") | ||
|
|
||
|
|
||
| class SSHTunnelNotFoundError(CommandException): |
- Move our SSH tunnel DAO, commands, model and exceptions to its own folder inside databases directory - Adjust some imports with the new paths - Add tests to our Delete command
hughhhh
approved these changes
Nov 16, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION