Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): Push websocket image #22181

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

Yann-J
Copy link
Contributor

@Yann-J Yann-J commented Nov 21, 2022

SUMMARY

This PR is a followup to #21954 which was missing the step to actually push the freshly-built superset-websocket image to Docker hub.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

This can only be tested after merge, since the publication step is only run on master. After successful merge, we should see an apache/superset-websocket image in Docker hub, with the same tags as the main image.

ADDITIONAL INFORMATION

  • Has associated issue: Publish websocket container #22126
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@craig-rueda
Copy link
Member

LGTM!

@craig-rueda craig-rueda merged commit 7408676 into apache:master Nov 24, 2022
@Yann-J
Copy link
Contributor Author

Yann-J commented Nov 24, 2022

Thanks @craig-rueda !

I see the build was successful, and the push was started off as expected, but then rejected by Docker Hub.

I think someone needs to just create the project in Docker Hub to unblock this - although I cannot be certain. In any case it's definitely something on Docker Hub side, which I don't think external contributors like me can fix...

@michael-s-molina
Copy link
Member

michael-s-molina commented Dec 1, 2022

@craig-rueda It seems the docker build step is failing on all master commits after this PR. Can you take a look?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants