-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ssh-tunnel): Refactor establishing raw connection with contextmanger #22366
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22366 +/- ##
=======================================
Coverage 66.91% 66.91%
=======================================
Files 1851 1851
Lines 70715 70709 -6
Branches 7766 7766
=======================================
- Hits 47320 47316 -4
+ Misses 21373 21371 -2
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@hughhhh would you mind adding at least a summary to the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring, it's a good clean up!
Let's just add a summary so that anyone who revisits this PR in the future has some context.
…anger (apache#22366) (cherry picked from commit 9c0d6c5)
SUMMARY
Refactoring how we instantiate raw connections with the new
@contextmanager
pattern for instantiating sqlalchemy engines. With this PR, we can do the samething but with raw connections within the engine. Instead of instantiating the 2 contextmangers to get access to the connections users of this functions will only have make one call to get the proper context.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION