-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(viz): rename v1 and v2 charts #22369
Conversation
7353235
to
a9d9e01
Compare
a9d9e01
to
e572fd9
Compare
Codecov Report
@@ Coverage Diff @@
## master #22369 +/- ##
=======================================
Coverage 66.86% 66.86%
=======================================
Files 1847 1847
Lines 70562 70562
Branches 7742 7742
=======================================
Hits 47179 47179
Misses 21382 21382
Partials 2001 2001
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the good housekeeping!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
SUMMARY
This makes the "v2" charts the "official ones" by removing the version suffix, and add "(legacy)" to the old ones that they're replacing.
AFTER
Now the viz switcher doesn't feature the v2 name (here I'm using generic x-axis):
BEFORE
Currently many charts feature a "v2" suffix:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION